Skip to content

[WIP] Use PF4 tertiary nav for tabs#3096

Closed
rhamilto wants to merge 1 commit intoopenshift:masterfrom
rhamilto:console-1429-tertiary-nav
Closed

[WIP] Use PF4 tertiary nav for tabs#3096
rhamilto wants to merge 1 commit intoopenshift:masterfrom
rhamilto:console-1429-tertiary-nav

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Oct 24, 2019 •
edited
Loading

Blocked by upstream bugs. See patternfly/patternfly-react#3200.

g9l7DsOjvt

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 24, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/core Related to console core functionality labels Oct 24, 2019
@rhamilto rhamilto mentioned this pull request Oct 24, 2019
Closed
@rhamilto rhamilto force-pushed the console-1429-tertiary-nav branch from 5c44e89 to 2a047df Compare October 29, 2019 22:40
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 29, 2019
@rhamilto rhamilto force-pushed the console-1429-tertiary-nav branch from 2a047df to 165b8bb Compare October 30, 2019 13:57
@rhamilto rhamilto force-pushed the console-1429-tertiary-nav branch from 165b8bb to cd27c92 Compare October 30, 2019 16:44
@rhamilto
Copy link
Member Author

rhamilto commented Oct 30, 2019

@janwright73, we currently have a bug where secondary tabs may not be visible at mobile. In discussing how to fix the bug, @spadgett and I agreed utilizing PF4's tertiary nav seems like the logical approach (which is what I've done in this PR); however, I found a number of blocker bugs with tertiary nav I documented in patternfly/patternfly-react#3200. Is it possible to get this bug fix expedited so we can move forward with this PR?

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2019

@rhamilto: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 5c44e8915395315588609f407b1debfadab3027c link /test e2e-aws-console-olm
ci/prow/e2e-gcp-console cd27c92 link /test e2e-gcp-console
ci/prow/analyze cd27c92 link /test analyze

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rhamilto rhamilto closed this Nov 13, 2019
@rhamilto rhamilto deleted the console-1429-tertiary-nav branch November 13, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rhamilto @openshift-ci-robot